-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: devcontainer fixes #219
Conversation
andreas-kurz
commented
May 7, 2024
- allow hotplug for all devices in the devcontainer
- show the whole workspace folder in the file explorer
- adds bash completion to the container
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
f17e79e
to
828ca7a
Compare
Limiting the mount to bus/usb only works with ST debuggers. So when the container is running it won't recognize any other debuggers being attached or removed. This is fixed by mounting the whole /dev into the container. Signed-off-by: Andreas Kurz <[email protected]>
This will show the whole workspace folder where bridle is cloned into in the file explorer. Before this change the file explorer only showed the cloned bridle repository. Signed-off-by: Andreas Kurz <[email protected]>
This will add bash completion to the container so that tab completion works for git commands in the terminal etc. Signed-off-by: Andreas Kurz <[email protected]>
828ca7a
to
65a1929
Compare
Use latest version of toolchain container provided by the zephyr project. Signed-off-by: Andreas Kurz <[email protected]>
65a1929
to
cbe7ade
Compare
Could you re-approve this PR? Wasn't able to merge it as Github seemed to be confused with rebasing the signed commits – don't know. I also bumped the container version to the latest release :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Bash completion is handled by installing the package via apt. This removes how it was done before installing the package. Signed-off-by: Andreas Kurz <[email protected]>
OK ... so what am I doing wrong. The only merge option i have from github si "Rebase and merge" which fails all the time because github can't "Rebase and merge" for me. The branch is rebased on main 😢 |
@andreas-kurz you have to merge (fast forward) locally and push as long as the main branch is protected to allow verified commits only – call me, if you need help following the command line instructions... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks