Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: devcontainer fixes #219

Merged
merged 5 commits into from
Jul 2, 2024
Merged

chore: devcontainer fixes #219

merged 5 commits into from
Jul 2, 2024

Conversation

andreas-kurz
Copy link
Contributor

  • allow hotplug for all devices in the devcontainer
  • show the whole workspace folder in the file explorer
  • adds bash completion to the container

@andreas-kurz andreas-kurz requested a review from rexut as a code owner May 7, 2024 15:32
rexut
rexut previously approved these changes May 30, 2024
Copy link
Member

@rexut rexut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@andreas-kurz andreas-kurz force-pushed the askz/fix-usb-mount branch 2 times, most recently from f17e79e to 828ca7a Compare June 5, 2024 08:45
Limiting the mount to bus/usb only works with ST debuggers. So when the
container is running it won't recognize any other debuggers being
attached or removed.
This is fixed by mounting the whole /dev into the container.

Signed-off-by: Andreas Kurz <[email protected]>
This will show the whole workspace folder where bridle is cloned into in
the file explorer. Before this change the file explorer only showed the
cloned bridle repository.

Signed-off-by: Andreas Kurz <[email protected]>
This will add bash completion to the container so that tab completion
works for git commands in the terminal etc.

Signed-off-by: Andreas Kurz <[email protected]>
Use latest version of toolchain container provided by the zephyr
project.

Signed-off-by: Andreas Kurz <[email protected]>
@andreas-kurz
Copy link
Contributor Author

@rexut

Could you re-approve this PR? Wasn't able to merge it as Github seemed to be confused with rebasing the signed commits – don't know.

I also bumped the container version to the latest release :)

tobiaskaestner
tobiaskaestner previously approved these changes Jul 1, 2024
Copy link
Contributor

@tobiaskaestner tobiaskaestner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.devcontainer/Dockerfile Show resolved Hide resolved
rexut
rexut previously approved these changes Jul 1, 2024
Copy link
Member

@rexut rexut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Bash completion is handled by installing the package via apt. This
removes how it was done before installing the package.

Signed-off-by: Andreas Kurz <[email protected]>
@andreas-kurz andreas-kurz dismissed stale reviews from rexut and tobiaskaestner via 7b64ed5 July 2, 2024 05:55
@andreas-kurz
Copy link
Contributor Author

OK ... so what am I doing wrong. The only merge option i have from github si "Rebase and merge" which fails all the time because github can't "Rebase and merge" for me. The branch is rebased on main 😢

@rexut
Copy link
Member

rexut commented Jul 2, 2024

OK ... so what am I doing wrong. The only merge option i have from github si "Rebase and merge" which fails all the time because github can't "Rebase and merge" for me. The branch is rebased on main 😢

@andreas-kurz you have to merge (fast forward) locally and push as long as the main branch is protected to allow verified commits only – call me, if you need help

following the command line instructions...

Copy link
Member

@rexut rexut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@rexut rexut merged commit 7b64ed5 into main Jul 2, 2024
3 checks passed
@rexut rexut deleted the askz/fix-usb-mount branch July 13, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants